867038 - [Clock][User Story] Alarms with selected audible tone and/or vibration

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Peter Dolanjski [:pdol]]

UCID: Clock-017

User Story:
As a user, I want to be able to set an alarm using a selected audible tone with vibration, a selected audible tone with no vibration or a vibration with no audible tone so that I can configure how I want to be alerted in different scenarios.

Comment 1

[Stephany Wilkes]

Quick question: Should the user be able to select and set multiple of these (i.e. an alarm with an audible tone and no vibration for my "Wake Up Alarm" but an alarm with no audible tone and vibration only for my "Get up and walk to this meeting" alarm)?

Comment 2

[Mike Lee [:mlee]]

CC'ing Michael Henretty (Developer) so he's aware of any changes or questions about the features expected behavior. I will create 1 or more dependent bugs to track the implementation of this feature's criteria.

Comment 3

[:CSchmoeckel]

Test Case #7761: [Clock] Users can set alarms with selected audible tone and/or vibration
Test case created to cover this new User Story for UCID: Clock-017

Comment 4

[Stephany Wilkes]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/49093145

Comment 5

[Mike Lee [:mlee]]

See Stephany's questions in comment #1.

When can we finalize on the expected behavior? I'd like to have Michael H start working on this asap.

Comment 6

[Peter Dolanjski [:pdol]]

(In reply to Stephany Wilkes from comment #1)
> Quick question: Should the user be able to select and set multiple of these
> (i.e. an alarm with an audible tone and no vibration for my "Wake Up Alarm"
> but an alarm with no audible tone and vibration only for my "Get up and walk
> to this meeting" alarm)?

That would be ideal.  This is how it currently works for the audible tones.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Sorry about my ignorance, this will be my first actual Gaia feature. 

A couple of questions: what form will the spec for this feature take when it's ready? Will it be comments in this bug, or perhaps in pivotal (which I currently don't have access to the project), or something in moztraps?

Also, do we have an estimate for when the spec for this feature will be ready?

Comment 8

[Stephany Wilkes]

Hi Michael,

No worries! I'm pretty new too. You can see the early draft of the spec in the linked bug (867374), at a URL in the comments.

I am flagging Brad on needinfo to ensure that the final spec is also attached to the spec bug.

Comment 9

[Mike Lee [:mlee]]

Stephany,

How much longer before UX is ready to hand-off to engineering?

We committed to have this implemented and in (uplifted to) 1.1 by June 7th.

Comment 10

[Stephany Wilkes]

Brad, can you upload the final? Thanks!

Comment 11

[Stephany Wilkes]

Michael, I've emailed Brad and Shane. Also, if this is high enough priority that engineering is gunning for it to be done for June 7, should it be a candidate for leo? (which is where we got the user story and the requirement)?

Comment 12

[Mike Lee [:mlee]]

Stephany,
Yes it's a commitment we've made for Leo.

Michael Treese,
Should we be marking this as a leo+ (blocker) and is there any confidentiality we need to set on this and related bugs?

Comment 13

[Mike Lee [:mlee]]

Henretty,
This is ready for you to start implementing. See bug 855426 for UX specs.

Comment 14

[Eric Pang [:epang] UX]

Attachment: Mock Up for Edit Alarm

Hi, there's been a request from Sergi for a revision to the mock up for the alarm settings screen.

Sergi, can you confirm this is correct?  Also, can you please let us know when the building blocks are ready for the new label style used in this bug?

Thanks!

Comment 15

[Sergi]

(In reply to Eric Pang [:epang] from comment #14)
> Created attachment 750660 [details]
> Mock Up for Edit Alarm
> 
> Hi, there's been a request from Sergi for a revision to the mock up for the
> alarm settings screen.
> 
> Sergi, can you confirm this is correct?  Also, can you please let us know
> when the building blocks are ready for the new label style used in this bug?
> 
> Thanks!

Perfect!

Thank you very much Eric

Comment 16

[Eric Pang [:epang] UX]

(In reply to Sergi from comment #15)
> (In reply to Eric Pang [:epang] from comment #14)
> > Created attachment 750660 [details]
> > Mock Up for Edit Alarm
> > 
> > Hi, there's been a request from Sergi for a revision to the mock up for the
> > alarm settings screen.
> > 
> > Sergi, can you confirm this is correct?  Also, can you please let us know
> > when the building blocks are ready for the new label style used in this bug?
> > 
> > Thanks!
> 
> Perfect!
> 
> Thank you very much Eric

Great, thanks Sergiy.  Can work be started on this, are the building blocks ready?

Comment 17

[Mike Lee [:mlee]]

scrumbug whiteboard tags (i.e. c= ) need to be separated by a space, appended commas break scrumbu.gs.

Comment 18

[Sergi]

Eric, i've been checking the mockup again i'm of the opinion it would make more sense to use a switch to activate/deactivate vibration, instead of using a value selector button. What do you think?

Comment 19

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Mike,
I have modified the Buttons BB to include labels on it after a request from Pavel: https://bugzilla.mozilla.org/show_bug.cgi?id=872464
As you are now the assignee, please let me know if that change works for you, as by now will be the only app applying that improvement correctly.
You have to use "<ul class="compact">" in your list.

Please I would like to know what works best for your markup:
ul.compact,
ol.compact {
  margin: 0 1.5rem 1.5rem 1.5rem;
}
as it is now, or:
ul.compact,
ol.compact {
  margin: 0 0 1.5rem 0;
}
Thanks

Comment 20

[Michael Henretty [:mikehenrty][:mhenretty]]

Arnau,

I appreciate the changes you have made to the BB, as they have made my markup/css much simpler. In response to your question:

Of the two, I like the first choice because it encourages a common horizontal margin for all compact button lists. However, rather than creating this space as margins, I would prefer using padding instead for two reasons:

1.) ul lists have a default left padding which I have to manually set to 0 (padding-left: 0) in addition to applying the button.css properties to get the intended results. At the least, button.css should set the left padding to 0 for compact lists for me.

2.) It would be nice to be able to set the background color or image of the compact list and have the background take up the entire screen. With margins on the ul list, the background will not cover everything, and I instead need to create a container element and apply the background to that to get the desired effect.

In any case, what we have right now is totally workable, and in the meantime I will use what is there. But if I had my choice, I would use padding :)

Thanks

Comment 21

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Michael,
Could you please modify buttons BB to change margins to paddings as it works best for you? It will be easier to include it in your patch than creating a new bug to fix this.
You could add me as a reviewer if you want to.
Thanks!

Comment 22

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to arnau from comment #21)
> Michael,
> Could you please modify buttons BB to change margins to paddings as it works
> best for you? It will be easier to include it in your patch than creating a
> new bug to fix this.
> You could add me as a reviewer if you want to.
> Thanks!

Will do, thanks Arnau!

Comment 23

[Askeing Yen[:askeing][:fyen]]

(In reply to Chris Schmoeckel from comment #3)
> Test Case #7761: [Clock] Users can set alarms with selected audible tone
> and/or vibration
> Test case created to cover this new User Story for UCID: Clock-017
The test cases with tag "clock-017":
https://moztrap.mozilla.org/manage/cases/?&filter-tag=1756

Comment 24

[Dylan Oliver [:doliver]]

Mike, can you provide the current status on this feature?

Comment 25

[Michael Henretty [:mikehenrty][:mhenretty]]

Hi Dylan, I'll be finishing up work on this in the next day or so, and getting it reviewed by the end of the week. Does that timeline work for you?

Comment 26

[Dylan Oliver [:doliver]]

Yes -- the goal is to have it complete and uplifted to v1-train by 6/3 so that it can be included in the QE3 test cycle, so it sounds like you're on track. Thanks!

Comment 27

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10097

Comment 28

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 755704 [details]
https://github.com/mozilla-b2g/gaia/pull/10097

><!doctype html>
><html lang=en>
><head>
><meta charset=utf-8>
><meta http-equiv="Refresh" content="0; url=https://github.com/mozilla-b2g/gaia/pull/10097" />
><title>Redirect to github...</title>
></head>
><body>
><p>Redirecting you to <a href="https://github.com/mozilla-b2g/gaia/pull/10097">https://github.com/mozilla-b2g/gaia/pull/10097</a></p>
></body>
></html>

Comment 29

[Michael Henretty [:mikehenrty][:mhenretty]]

Arnau,

Could you take a look at the building block change? I'll have someone else actually review the changes to the alarm clock, I just want to make sure you're on board with the `/shared/` changes.

It's a small change to /shared/style/buttons.css
https://github.com/mozilla-b2g/gaia/pull/10097/files#diff-8

Thanks

Comment 30

[[e-mail], [e-mail]]

Hi Michael,

If you need a reviewer for functionality with vibration, I can help you on it.

Comment 31

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Michael,
Works for me. Thanks!

Comment 32

[Michael Henretty [:mikehenrty][:mhenretty]]

Ian, given your experience with the clock app, that would be great.

Comment 33

[[e-mail], [e-mail]]

Attachment: selector broken after went into each option

Michael,
It does not work for me after went into each option. I also attache the screen shot for you. My build version is 20130528070209. But I don't think it is relative to Gecko. Maybe I miss some patch?

Comment 35

[Eric Pang [:epang] UX]

(In reply to Sergi from comment #18)
> Eric, i've been checking the mockup again i'm of the opinion it would make
> more sense to use a switch to activate/deactivate vibration, instead of
> using a value selector button. What do you think?

Hi Sergi, sorry for the late response.  We decided to use a drop down for the following reasons:
1. This opens itself to further vibration settings in future versions as well, for instnace "vibrate on ring, vibrate on silent" etc.
2. We were also worried the toggle would look out of place with all the other drop downs
Let me know what you think, thanks!

Comment 36

[Sergi]

(In reply to Eric Pang [:epang] from comment #35)
> (In reply to Sergi from comment #18)
> > Eric, i've been checking the mockup again i'm of the opinion it would make
> > more sense to use a switch to activate/deactivate vibration, instead of
> > using a value selector button. What do you think?
> 
> Hi Sergi, sorry for the late response.  We decided to use a drop down for
> the following reasons:
> 1. This opens itself to further vibration settings in future versions as
> well, for instnace "vibrate on ring, vibrate on silent" etc.
> 2. We were also worried the toggle would look out of place with all the
> other drop downs
> Let me know what you think, thanks!

I see. If the case is like what you point out about having multiple options it may make sense, but, right now, using a value selector to activate/deactivate something looks weird.

Anyway, let's leave this as it is, and maybe it will make more sense in the future when we can display more options.

Thanks!

Comment 37

[Gareth Aye [:gaye] (back from PTO)]

Mirrored comment from PR:

I love the work you did here. I have some comments, but most of the issues are pretty small. This needs tests though like we discussed, so flag me again on bugzilla when you're ready for another review pass.

Also: if you could commit on top of what you've done and hold off on squashing until we're done with the review, so that it's easy for me to look at the incremental changes you're making, that'd be great. Thanks Mike!

Comment 38

[Michael Henretty [:mikehenrty][:mhenretty]]

Gareth, I added test, and responded to you comments inline. Let me know what you think.

Comment 39

[Gareth Aye [:gaye] (back from PTO)]

Thanks Mike! You did an *excellent* job; I really appreciate your work here. +++

Landed in master: 02cd2ff72882862c6c707d4250e049f0210414c9

Comment 40

[Gareth Aye [:gaye] (back from PTO)]

Don't uplift this yet! mhenretty found an issue that we have to resolve first!

Comment 41

[Michael Henretty [:mikehenrty][:mhenretty]]

As per :doliver, I opened a new bug to track this problem, and am reclosing this one.

https://bugzilla.mozilla.org/show_bug.cgi?id=879899

Comment 42

[Michael Henretty [:mikehenrty][:mhenretty]]

Uplifted to v1-train.

Comment 43

[Ryan VanderMeulen [:RyanVM]]

This caused bustage on v1-train. Please fix or backout.
https://tbpl.mozilla.org/php/getParsedLog.php?id=23916571&tree=Mozilla-B2g18

Comment 44

[Axel Hecht [:Pike]]

This also changed the alarm.placeholder string without changing the ID.

That change won't be picked up unless there's a follow up fix.

Comment 45

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks for the review Alex. I apologize about my ignorance, can you give me more information about this issue? Do I need to change the data-l10n-id (perhaps to something like "alarmName") before the l10n tools realize there was a change to the placeholder string?

Comment 46

[Francesco Lodolo [:flod]]

(In reply to Michael Henretty [:mikehenrty] from comment #45)
> Do I need to change the data-l10n-id (perhaps to something like 
> "alarmName") before the l10n tools realize there was a change 
> to the placeholder string?

Exactly. 

By changing the id, an existing localization will be invalidated since the new id is untranslated. If you don't do that, you'll never know if localizers noticed this change and updated their localization.

Comment 47

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Pull Request (https://github.com/mozilla-b2g/gaia/pull/10299)

l10n team, please verify that this patch will update the language string.

Comment 48

[Francesco Lodolo [:flod]]

This is confusing.

In the original patch you changed alarm.placeholder to "Alarm name" (from the original "Alarm").

Now you create a new id (alarmName) and you set it to "Alarm" instead of "Alarm name".
As it is, alarmName.placeholder is never used. So IMO you should get rid of alarmName and set data-l10n-id="alarmName.placeholder"

Comment 49

[Michael Henretty [:mikehenrty][:mhenretty]]

Correct me if I'm wrong, but I believe the way it works is this: if you want to localize an html attribute (like placeholder, but also things like "alt", or "value") you use this format:

<l10n-id>.<attribute>

So, in this case, I gave my input the "alarmName" id, and then I set the .placeholder string to "Alarm name" in the properties file. If I set my the data-l10n-id to "alarmName.placeholder" as you suggested, the placeholder text doesn't get translated. However, I can remove the alarmName = "Alarm" property, since that never gets used. Would that make it less confusing?

Also, can you point me to some documentation on these property files?

Comment 50

[Axel Hecht [:Pike]]

Comment on attachment 760528 [details]
Pull Request (https://github.com/mozilla-b2g/gaia/pull/10299)

I have to admit, I don't know the l10n api good enough to review this. Can you ask a gaia peer for review instead?

Comment 51

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/2907a63373d29090250e229d60129fe5120258c6

Comment 52

[Kevin Grandon :kgrandon]

This has been manually uplifted to the v1-train as well: https://github.com/mozilla-b2g/gaia/commit/35f34c31fe2dab965e2409b92e7b7307c5b35ba9

We should be good to go here. Nice work Michael!

Comment 53

[Francesco Lodolo [:flod]]

(In reply to Michael Henretty [:mikehenrty] from comment #49)
> Correct me if I'm wrong, but I believe the way it works is this: if you want
> to localize an html attribute (like placeholder, but also things like "alt",
> or "value") you use this format:
> 
> <l10n-id>.<attribute>

Sorry, my mistake. I never realized that the l10n API was using that syntax to identify attributes. And thanks for removing the unused string.

Comment 54

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 35f34c31fe2dab965e2409b92e7b7307c5b35ba9

Comment 55

[William Hsu [:whsu]]

Hi, all,

Thanks for your help!
I did a quick verification on following patch.
* Test Build:(Mozilla-b2g18_v1_1_0_hd-unagi/2013-07-01-07-02-15)
 + Mercurial-Information:
   - Gecko: "f686f56c11d6"
   - Gaia: ""
 + Git-Information:
   - Gecko: ""
   - Gaia: "c7472acec84f0d4527cdd6fd555d289e1d3e1d1d"

It works as expected.

Test cases:
1. Sound + Vibration -> Pass
2. Sound + No vibration -> Pass
3. No sound + Vibration -> Pass
4. No sound + No vibration -> Pass

Also, attaching the latest UI for your reference.

Comment 56

[William Hsu [:whsu]]

Attachment: Create a new alarm

Comment 57

[William Hsu [:whsu]]

Attachment: Edit an existing alarm

Comment 58

[sbogati]

Issue no longer repro on Leo device 
Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eef
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1
Alarm working as expected. 
Sound + Vibration, Sound + No vibration, No sound + Vibration,
No sound + No vibration.